• mtrofin's avatar
    Heap::CopyCode does not correctly handle references into NEW_SPACE. · c0dfc8d8
    mtrofin authored
    A fix would be to walk the reloc info and RecordWriteIntoCode. Doing
    so, however, upsets a scavenger DCHECK.
    
    We stumbled upon this issue because we were placing wasm objects
    (fixed arrays) in NEW_SPACE, rather than OLD_SPACE. These fixed
    arrays were subsequently referenced from Code objects, which were
    then cloned.
    
    The current CL ensures wasm constructs are allocated in OLD_SPACE,
    by pre-tenuring them (consistent with other wasm allocations). In
    addition, it adds a DCHECK for CopyCode clarifying its lack of support
    for references to NEW_SPACE.
    
    We can investigate in a subsequent CL making CopyCode more robust,
    pending understanding of the Scavenger's assumptions.
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2201663003
    Cr-Commit-Position: refs/heads/master@{#38263}
    c0dfc8d8
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...