• Thibaud Michaud's avatar
    [wasm] Fix interpreter Ref in unreachable code · 140271f2
    Thibaud Michaud authored
    For "else" and "catch" statements, the Ref to the end label should only
    be added if the current block is unreachable, not the parent block.
    
    In the added regression test, the "true" block ends in an unreachable
    state with a stack height less than the target height of the end label.
    This is valid due to the semantics of unreachable code, but we should
    not add the Ref in this case because its stack height is invalid.
    
    R=clemensb@chromium.org
    
    Fixed: chromium:1092130
    Change-Id: Iebaf5e7d6516278ccd3c8268ac331069e109d882
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2412181
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69934}
    140271f2
Name
Last commit
Last update
..
OWNERS Loading commit data...
control-transfer-unittest.cc Loading commit data...
decoder-unittest.cc Loading commit data...
function-body-decoder-unittest.cc Loading commit data...
leb-helper-unittest.cc Loading commit data...
loop-assignment-analysis-unittest.cc Loading commit data...
module-decoder-unittest.cc Loading commit data...
simd-shuffle-unittest.cc Loading commit data...
streaming-decoder-unittest.cc Loading commit data...
subtyping-unittest.cc Loading commit data...
trap-handler-posix-unittest.cc Loading commit data...
trap-handler-win-unittest.cc Loading commit data...
trap-handler-x64-unittest.cc Loading commit data...
wasm-code-manager-unittest.cc Loading commit data...
wasm-compiler-unittest.cc Loading commit data...
wasm-gdbserver-unittest.cc Loading commit data...
wasm-macro-gen-unittest.cc Loading commit data...
wasm-module-builder-unittest.cc Loading commit data...
wasm-module-sourcemap-unittest.cc Loading commit data...