• Jakob Gruber's avatar
    [regexp] Handle marker value 0x10ffff in MakeRangeArray · bfa681ff
    Jakob Gruber authored
    Unfortunately, CharacterRanges may use 0x10ffff as a marker value
    signifying 'highest possible code unit' irrespective of whether the
    regexp instance has the unicode flag or not. This value makes it
    through RegExpCharacterClass::ToNode unmodified (since no surrogate
    desugaring takes place without /u). Correctly mask out the 0xffff
    value for purposes of building our uint16_t range array.
    
    Note: It'd be better to never introduce 0x10ffff in the first place,
    but given the irregexp pipeline's lack of hackability I hesitate to
    change this - we are sure to rely on it implicitly in other spots.
    
    Drive-by: Refactors.
    
    Fixed: chromium:1264508
    Bug: v8:11069
    Change-Id: Ib3c5780e91f682f1a6d15f26eb4cf03636d93c25
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256549
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77673}
    bfa681ff
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...