• Zhi An Ng's avatar
    Revert "[wasm] Simplify module creation" · bf7284b9
    Zhi An Ng authored
    This reverts commit 425fa3ae.
    
    Reason for revert: test failure https://bugs.chromium.org/p/v8/issues/detail?id=9554 reverting the root cause has merge conflicts due to changes in same file
    
    Original change's description:
    > [wasm] Simplify module creation
    > 
    > This includes WasmEngine::NewNativeModule() and WasmModuleObject::New().
    > The intent is to make the various ways of creating a module (sync,
    > async, deserialize, import) more similar.
    > 
    > After this change, a NativeModule will always be created before a
    > WasmModuleObject. This will make it easier to look up a cached
    > NativeModule given its wire bytes.
    > 
    > The following changes are made:
    > 
    > * Use WasmCodeManager::EstimateNativeModuleCodeSize() to find the code
    >   size estimate by default. A different code size estimate is only used in
    >   tests.
    > * Change CompileJsToWasmWrappers() to allocate a new FixedArray instead of
    >   assuming the array was created with the correct size. This simplifies
    >   WasmModuleObject::New(), and matches what CompileToNativeModule()
    >   does.
    > * Remove the WasmModuleObject::New() constructor that creates a
    >   NativeModule. This case was only used in DeserializeNativeModule() and
    >   in test code.
    > 
    > Change-Id: I6bdfc425057f92de11abbbf702d052d40aa8267d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1717497
    > Commit-Queue: Ben Smith <binji@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62925}
    
    TBR=binji@chromium.org,ahaas@chromium.org,clemensh@chromium.org
    
    Change-Id: I8dcad7ddcd4601f657b6263bf22009907284fce3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1719230Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62926}
    bf7284b9
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...