• Yang Guo's avatar
    [serialize] explicitly serialize code content upfront. · bebaffb9
    Yang Guo authored
    The serializer performs two passes over the code. The first pass copies out the
    code content verbatim, the second pass visits references recorded in the reloc
    info.
    
    So far the first pass is implicit and happens as part of the second pass, when
    we encounter a non-HeapObject reference when iterating the code object.  That
    however does not work for internal references. So we hit an assertion if the
    first non-HeapObject reference we see is an internal reference.
    
    This change explicitly triggers the first pass.
    
    R=petermarshall@chromium.org
    
    Bug: v8:6817
    Change-Id: I1ee9949e10b7d9409986da83be22ac6287785f9f
    Reviewed-on: https://chromium-review.googlesource.com/663867Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48010}
    bebaffb9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...