• Michael Lippautz's avatar
    Revert "[heap, api] Check assumptions for embedder fields on set" · bcd0fa55
    Michael Lippautz authored
    This reverts commit 61193620.
    
    Reason for revert: Blocking roll: https://chromium-review.googlesource.com/c/chromium/src/+/3802992/
    
    Original change's description:
    > [heap, api] Check assumptions for embedder fields on set
    >
    > Previously, we would set embedder fields and do type checks (on
    > embedder fields) in the GC. This does not work nicely as embedder
    > fields contain system pointers whereas we can only operate with
    > tag-aligned reads/writes. The end result of assembling pointers was
    > somtimes broken for concurrent marking.
    >
    > In this CL we reverse the mode and check assumptions when writing the
    > fields. From Blink we generally only write once and use the fields in
    > the GC and via reads multiple times.
    >
    > We assume, that when running with CppHeap, any pointer on an instance
    > field that points into CppHeap, also has the type field set with the
    > appropriate tracing information. In debug builds we also verify that
    > the embedder field indeed points to the start of an Oilpan object.
    >
    > Bug: chromium:1337690
    > Change-Id: I9f9a8e691cdcf666861a455dcf8f65f2fe80b034
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788206
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82120}
    
    Bug: chromium:1337690
    Change-Id: Iaece8f51883c7d001fb18ef48faaf271c48b8f11
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804245
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Owners-Override: Leszek Swirski <leszeks@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#82127}
    bcd0fa55
Name
Last commit
Last update
..
base Loading commit data...
cppgc Loading commit data...
cppgc-js Loading commit data...
third-party Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
allocation-observer.cc Loading commit data...
allocation-observer.h Loading commit data...
allocation-result.h Loading commit data...
allocation-stats.h Loading commit data...
array-buffer-sweeper.cc Loading commit data...
array-buffer-sweeper.h Loading commit data...
base-space.cc Loading commit data...
base-space.h Loading commit data...
basic-memory-chunk.cc Loading commit data...
basic-memory-chunk.h Loading commit data...
code-object-registry.cc Loading commit data...
code-object-registry.h Loading commit data...
code-range.cc Loading commit data...
code-range.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
collection-barrier.cc Loading commit data...
collection-barrier.h Loading commit data...
combined-heap.cc Loading commit data...
combined-heap.h Loading commit data...
concurrent-allocator-inl.h Loading commit data...
concurrent-allocator.cc Loading commit data...
concurrent-allocator.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
conservative-stack-visitor.cc Loading commit data...
conservative-stack-visitor.h Loading commit data...
embedder-tracing-inl.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
evacuation-allocator-inl.h Loading commit data...
evacuation-allocator.h Loading commit data...
factory-base-inl.h Loading commit data...
factory-base.cc Loading commit data...
factory-base.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
finalization-registry-cleanup-task.cc Loading commit data...
finalization-registry-cleanup-task.h Loading commit data...
free-list-inl.h Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer-inl.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-allocator-inl.h Loading commit data...
heap-allocator.cc Loading commit data...
heap-allocator.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap-layout-tracer.cc Loading commit data...
heap-layout-tracer.h Loading commit data...
heap-write-barrier-inl.h Loading commit data...
heap-write-barrier.cc Loading commit data...
heap-write-barrier.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
index-generator.cc Loading commit data...
index-generator.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
large-spaces.cc Loading commit data...
large-spaces.h Loading commit data...
linear-allocation-area.h Loading commit data...
list.h Loading commit data...
local-factory-inl.h Loading commit data...
local-factory.cc Loading commit data...
local-factory.h Loading commit data...
local-heap-inl.h Loading commit data...
local-heap.cc Loading commit data...
local-heap.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking-barrier-inl.h Loading commit data...
marking-barrier.cc Loading commit data...
marking-barrier.h Loading commit data...
marking-visitor-inl.h Loading commit data...
marking-visitor.h Loading commit data...
marking-worklist-inl.h Loading commit data...
marking-worklist.cc Loading commit data...
marking-worklist.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-allocator.cc Loading commit data...
memory-allocator.h Loading commit data...
memory-chunk-inl.h Loading commit data...
memory-chunk-layout.cc Loading commit data...
memory-chunk-layout.h Loading commit data...
memory-chunk.cc Loading commit data...
memory-chunk.h Loading commit data...
memory-measurement-inl.h Loading commit data...
memory-measurement.cc Loading commit data...
memory-measurement.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
new-spaces-inl.h Loading commit data...
new-spaces.cc Loading commit data...
new-spaces.h Loading commit data...
object-start-bitmap-inl.h Loading commit data...
object-start-bitmap.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
paged-spaces-inl.h Loading commit data...
paged-spaces.cc Loading commit data...
paged-spaces.h Loading commit data...
parallel-work-item.h Loading commit data...
parked-scope.h Loading commit data...
progress-bar.h Loading commit data...
promote-young-generation.cc Loading commit data...
promote-young-generation.h Loading commit data...
read-only-heap-inl.h Loading commit data...
read-only-heap.cc Loading commit data...
read-only-heap.h Loading commit data...
read-only-spaces.cc Loading commit data...
read-only-spaces.h Loading commit data...
reference-summarizer.cc Loading commit data...
reference-summarizer.h Loading commit data...
remembered-set-inl.h Loading commit data...
remembered-set.h Loading commit data...
safepoint.cc Loading commit data...
safepoint.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
weak-object-worklists.cc Loading commit data...
weak-object-worklists.h Loading commit data...