• Nico Weber's avatar
    Fix Wbitwise-instead-of-logical warnings · bc4ea5e0
    Nico Weber authored
    `a && b` only evaluates b if a is true. `a & b` always evaluates
    both a and b. If a and b are of type bool, `&&` is usually what you
    want, so clang now warns on `&` where both arguments are of type bool.
    
    This warning fires twice in v8.
    
    1. In branch-elimination.cc, we have the rare case where we _want_
       to evaluate both branches so that both reduced_ and node_conditions_
       are always updated. To make this more obvious, reorder the code a
       bit. (The warning can also be suppressed by casting one of the two
       expressions to int, but the reordering seems clearer.)
    
    2. The other case is an actual (inconsequential) typo, so use || here.
    
    Bug: chromium:1255745
    Change-Id: I62ba45451ee2642265574d28c646d85f5a18670b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212891
    Auto-Submit: Nico Weber <thakis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77314}
    bc4ea5e0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...