• Nico Weber's avatar
    Fix Wbitwise-instead-of-logical warnings · bc4ea5e0
    Nico Weber authored
    `a && b` only evaluates b if a is true. `a & b` always evaluates
    both a and b. If a and b are of type bool, `&&` is usually what you
    want, so clang now warns on `&` where both arguments are of type bool.
    
    This warning fires twice in v8.
    
    1. In branch-elimination.cc, we have the rare case where we _want_
       to evaluate both branches so that both reduced_ and node_conditions_
       are always updated. To make this more obvious, reorder the code a
       bit. (The warning can also be suppressed by casting one of the two
       expressions to int, but the reordering seems clearer.)
    
    2. The other case is an actual (inconsequential) typo, so use || here.
    
    Bug: chromium:1255745
    Change-Id: I62ba45451ee2642265574d28c646d85f5a18670b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212891
    Auto-Submit: Nico Weber <thakis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77314}
    bc4ea5e0
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...