• Leszek Swirski's avatar
    [offthread] Add an OffThreadIsolate · 7a20b6b9
    Leszek Swirski authored
    The Factory/OffThreadFactory allows us to cleanly separate object
    construction behaviour between main-thread and off-thread in a
    syntactically consistent way (so that methods templated on the factory
    type can be made to work on both).
    
    However, there are cases where we also have to access the Isolate, for
    handle creation or exception throwing. So far we have been pushing more
    and more "customization points" into the factories to allow these
    factory-templated methods to dispatch on this isolate behaviour via
    these factory methods. Unfortunately, this is an increasing layering
    violation between Factory and Isolate, particularly around exception
    handling.
    
    Now, we introduce an OffThreadIsolate, analogous to Isolate in the same
    way as OffThreadFactory is analogous to Factory. All methods which were
    templated on Factory are now templated on Isolate, and methods which
    used to take an Isolate, and which were recently changed to take a
    templated Factory, are changed/reverted to take a templated Isolate.
    OffThreadFactory gets an isolate() method to match Factory's.
    
    Notably, FactoryHandle is changed to "HandleFor", where the template
    argument can be either of the Isolate type or the Factory type (allowing
    us to dispatch on both depending on what is available).
    
    Bug: chromium:1011762
    Change-Id: Id144176f7da534dd76f3d535ab2ade008b6845e3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030909
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66101}
    7a20b6b9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...