• Milad Fa's avatar
    PPC/s390: [safepoints] Various refactors · bb9004f3
    Milad Fa authored
    Port c7e47c30
    
    Original Commit Message:
    
        A collection of smallish cleanups and improvements for safepoints.
    
        Maintainability:
        - The class names were not very clear; move Safepoint inside
          SafepointTableBuilder to clarify that this wrapper class is used
          during codegen.
        - Rename DefinePointerSlot/DefineRegister to
          DefineTaggedStackSlot/DefineTaggedRegister for clarity.
        - Use named constants instead of -1.
        - DefineTaggedRegister has no connection to kNoDeoptIndex, remove
          the DCHECK and comment.
        - Remove the unused kNumSafepointRegisters constant + other dead code.
        - Small clarifications in CommonFrame::IterateCompiledFrame.
        - Rename has_safepoint_info to uses_safepoint_table and refactor s.t.
          `stack_slots` can be used when `uses_safepoint_table == false`. In
          this case it just returns 0.
    
        Perf:
        - During codegen, represent stack slots as a growable bit vector
          instead of a list of int indices. Extend GrowableBitVector
          functionality to support the above.
        - Track the minimum index instead of iterating all stack slots in
          all safepoints before encoding.
    
    R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
    BUG=
    LOG=N
    
    Change-Id: Ifef2d95f1e4a064d85d4ce437b1d12ae9796336f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484701Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#79237}
    bb9004f3
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...