• Clemens Backes's avatar
    [API] Use proper C++ methods to implement type checks · 42f2e1fc
    Clemens Backes authored
    The {TYPE_CHECK} macro used an ancient pattern to check for
    assignability, by assigning to a static_casted nullptrs of the
    respective types.
    C++11 introduced standard library helpers to express this more
    naturally. The most direct translation would have been to use
    {std::is_assignable} or {std::is_convertible} on the pointer types, but
    in most cases we can be even more strict and force one type to be a
    proper subtype of the other.
    The only exception is {ReturnValue}, which allows to assign anything if
    it's void.
    
    R=ulan@chromium.org
    
    Bug: v8:10155
    Change-Id: I41c1103e0206514c8700c47a0bf107ad704cfc47
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093497Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66695}
    42f2e1fc
Name
Last commit
Last update
..
libplatform Loading commit data...
APIDesign.md Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol-1.3.json Loading commit data...
js_protocol.pdl Loading commit data...
v8-fast-api-calls.h Loading commit data...
v8-inspector-protocol.h Loading commit data...
v8-inspector.h Loading commit data...
v8-internal.h Loading commit data...
v8-platform.h Loading commit data...
v8-profiler.h Loading commit data...
v8-util.h Loading commit data...
v8-value-serializer-version.h Loading commit data...
v8-version-string.h Loading commit data...
v8-version.h Loading commit data...
v8-wasm-trap-handler-posix.h Loading commit data...
v8-wasm-trap-handler-win.h Loading commit data...
v8.h Loading commit data...
v8config.h Loading commit data...