• wingo's avatar
    Fix parsing of arrow function formal parameters · bb43d6c0
    wingo authored
    Not all parenthesized AssignmentExpressions whose components are valid
    binding patterns are valid arrow function formal parameters.  In
    particular (a,b,c)() is not valid, and in general the existing code
    wasn't catching the tail productions of ConditionalExpression,
    BinaryExpression, PostfixExpression, LeftHandSideExpression,
    and MemberExpression.
    
    Thanks to Adrian Perez for the test case.
    
    BUG=v8:4211
    LOG=Y
    R=rossberg@chromium.org
    
    Review URL: https://codereview.chromium.org/1306583002
    
    Cr-Commit-Position: refs/heads/master@{#30286}
    bb43d6c0
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...