• Leszek Swirski's avatar
    [handles] Add a PatchValue method for Handle · ba088da2
    Leszek Swirski authored
    We currently have a pattern of setting a dereferenced Handle location to
    update that Handle's value:
    
      *handle.location() = new_value.ptr()
    
    This is slightly opaque, and definitely not type-safe, so add a new
    Handle<T>::PatchValue method which does this operation.
    
    Ideally we would make Handle::location() return a const pointer to
    discourage this sort of use, but there's a bunch of places where that
    location pointer is used and passed around as a Handle surrogate, so
    those would have to be updated first.
    
    Change-Id: I157f7e2473ed1b86f7a93cae260b0932fed0ad88
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424249
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70088}
    ba088da2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...