• Patrick Thier's avatar
    Improve error messages for property access on null/undefined · 24c626c1
    Patrick Thier authored
    Only print the property name when accessing null/undefined if we can
    convert it to a string without causing side effects.
    If we can't, omit the property name in the error message.
    This should avoid confusion when the key is an object with toString().
    E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    Object]' anymore, which was misleading since the property accessed would
    be 'a', but we can't evaluate the key without side effects.
    
    Bug: v8:11365
    Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75250}
    24c626c1
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...