• Simon Zünd's avatar
    [array] Only use fast-path in Array.p.fill for JSArrays · b87e7623
    Simon Zünd authored
    This CL changes Array.p.fill to use the baseline implementation
    for everything other than JSArray.
    
    One of the reasons is that shadowing the length property on
    TypedArrays (and other ElementsKinds) is allowed and should be
    respected by Array.p.fill. The fast-path for fill for TypedArrays
    expects the indices to be clamped to the actual length of the
    underlying backing store and not to some length property.
    
    While this mismatch (and others) could probably be handled properly,
    we do the conservative thing and only use the fast-path for specific
    JSArrays.
    
    R=jgruber@chromium.org
    
    Bug: chromium:865312
    Change-Id: Ib3050e3bfc22d47ca8597b6df34788dc2b59b6e1
    Reviewed-on: https://chromium-review.googlesource.com/1142772Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@google.com>
    Cr-Commit-Position: refs/heads/master@{#54558}
    b87e7623
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...