• Jakob Gruber's avatar
    [compiler] Use PersistentMap in store-store elimination · b8127393
    Jakob Gruber authored
    Store-store elimination can potentially allocate many temporary data
    structures, all of which are contained in its so-called temporary
    zone. The zone is 'temporary' in the sense of only existing for the
    lifetime of the StoreStoreEliminationPhase; but all allocated memory
    remains alive until the phase terminates.
    
    Investigation of a pathological case (see the linked bug) showed this
    zone reaching a size of 4GB. The cause in this specific case was the
    UnobservableSet data structure, conceptually an immutable set (i.e.
    each operation creates a full copy). This CL changes the
    UnobservableSet to use a PersistentMap backing store rather than a
    ZoneSet. PersistentMap is intended for exactly this use-case, since
    copies are basically free and updates only change small parts of the
    data structure.
    
    Memory consumption for the linked pathological case drops from 4GB to
    70MB and execution speeds up from 20s to 17s.
    
    Bug: v8:9574
    Change-Id: I902b27f1aa42b88ddd905ee941df24028a68a9bd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795351
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63819}
    b8127393
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...