• Camillo Bruni's avatar
    Reland "[flags] Skip --random-seed in FlagList::Hash" · b704bc09
    Camillo Bruni authored
    This is a reland of 9fe53c4f
    
    - Fix data-race by using an atomic for flag_hash;
    - Make sure flag_hash != 0
    - Initialize flag_hash in V8::InitializeOncePerProcessImpl
    - Clear flag_hash in more cases
    
    Original change's description:
    > [flags] Skip --random-seed in FlagList::Hash
    >
    > Node and friends use --random-seed to temporary reset the seed for
    > predictable code-cache creation. To allow custom random seeds at runtime
    > the flag is reset for encoding the FlagList::Hash in the snapshots.
    >
    > We will soon disallow changing flags via the API after V8 has been
    > initialized. In order to make node work we will exclude --random-seed
    > from the FlagList::Hash calculation.
    >
    > Drive-by-fix:
    > * Lazily initialize flag_hash instead of calculating it after every call
    >   to SetFlagsFromString / EnforceFlagImplications.
    > * Simplify hash string source creation since out << flag now includes
    >   the full flag information
    >
    > Bug: v8:12309
    > Change-Id: I1a168f4702d8c4d160ff12fdbea881731e4ea8b6
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218159
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77345}
    
    Bug: v8:12309
    Change-Id: I12cd2931d81dc74e07a4da3564e4bf8dd151300a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218981
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Auto-Submit: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77373}
    b704bc09
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...