• adamk's avatar
    [es6] Self-assignment in a default parameter initializer should throw · b6e9f625
    adamk authored
    The first bug was that there are two different "initialization positions"
    passed into PatternRewriter::DeclareAndInitializeVariables, and we weren't
    setting them all properly for this case.
    
    After further code review, it became clear that we weren't even recording
    the correct position (the end of the initializer expression).
    
    The combination of those two bugs caused the hole check elimination code
    in full-codegen to skip emitting a hole check.
    
    This patch takes care of both of those things. A follow-up will try
    to reduce the number of "initializer positions" we track in the
    variable declaration code.
    
    R=littledan@chromium.org
    BUG=v8:4568
    LOG=n
    
    Review URL: https://codereview.chromium.org/1468143004
    
    Cr-Commit-Position: refs/heads/master@{#32237}
    b6e9f625
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...