• xaxxon's avatar
    Make handle ctors explicit · b6c9b703
    xaxxon authored
    Without this change, the v8::Local<> constructor will be picked up by the
    compiler as an option for an implicit cast for any pointer type.  This leads
    to bad error messages when accidentally passing an erroneous pointer type to
    a function wanting a Local<> (complains about a pointer assignment in Local<>'s
    constructor as opposed to a bad type for the parameter of the function being
    called) and also causes ambiguity errors where none should exist when calling
    overloaded functions (for example a function taking either a std::string or a
    v8::Local<v8::Script> cannot be called with a const char * because the compiler
    sees both types as being constructable with a const char *).
    
    R=jochen@chromium.org
    BUG=
    
    Review URL: https://codereview.chromium.org/1647833005
    
    Cr-Commit-Position: refs/heads/master@{#33602}
    b6c9b703
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...