• vogelheim's avatar
    Fix Scanner invariants w/ literal buffers. · b68df2d2
    vogelheim authored
    This isn't the most elegant fix, but I'd prefer to not rework the logic
    right now. What happens is:
    - Most parts of the Scanner use nullptr to mean, no literal buffer.
    - The bookmarking logic may end up with a state where there's a non-nullptr
      literal buffer, but it's empty. (length 0)
    - These are functionally equivalent, so there's no 'real' bug.
    - But it makes it hard to reason. This patch hence checks for length-0
      literal buffers, and uses nullptr instead.
    
    R=marja@chromium.org
    BUG=chromium:639191 v8:4947
    
    Review-Url: https://codereview.chromium.org/2258073003
    Cr-Commit-Position: refs/heads/master@{#38756}
    b68df2d2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...