• Simon Zünd's avatar
    Reland "[snapshot] Add '.note.GNU-stack' marker section for ELF snapshots" · b658d9c7
    Simon Zünd authored
    This is a reland of f24e9958
    
    Speculatively relanding the CL. LLD ignores the added section, so the
    output should not be any different. The issue was also not reproducible
    locally. Keeping an eye on the bot/roll to quickly revert, in case this
    CL really breaks the deterministic build.
    
    Original change's description:
    > [snapshot] Add '.note.GNU-stack' marker section for ELF snapshots
    >
    > This snapshot adds a marker section to the output assembly of
    > mksnapshot. Omitting this section can imply an executable stack, which
    > can result in linker warnings.
    >
    > R=jgruber@chromium.org
    >
    > Change-Id: I6f5dacb24de3a852faf6ce0caf18c32b499ba5a9
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687669
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62504}
    
    TBR=jgruber@chromium.org
    
    Bug: chromium:981138
    Change-Id: I2ddbaa7aa33f125ea0a0854cd9a94108c3a3845f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690825Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62560}
    b658d9c7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...