• ulan's avatar
    [heap] Ensure that the sweeper does not lose unswept pages. · b6219871
    ulan authored
    This fixes a race between the sweeper and the array buffer tracker
    that causes the sweeper to skip unswept pages.
    
    The scenario:
    1. Mark-compact GC adds page p to the sweeping_list_ of the sweeper.
    2. GC finishes, the main thread starts executinng JS.
    3. The main thread takes p->mutex to unregister an array buffer.
    4. A sweeper thread removes p from the sweeping_list_ and tries to
       take p->mutex. The try fails. The sweeper drops p and continues
       to the next page.
    5. During selection of evacuation candidate in the next GC we hit
       page->SweepingDone() assert.
    
    BUG=chromium:650314
    
    Review-Url: https://codereview.chromium.org/2484153004
    Cr-Commit-Position: refs/heads/master@{#40857}
    b6219871
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...