• Jakob Kummerow's avatar
    [bigint] Fix accidental input modification in Divide · b5997de8
    Jakob Kummerow authored
    "AbsoluteDivSmall" had a shortcut path for abs(divisor) == 1 where
    it would simply return the dividend as result. However, its caller
    "Divide" was blissfully ignorant of this trick and would therefore
    simply set the value's sign as needed, modifying the input.
    This CL prevents that, while continuing to avoid the full division
    algorithm for abs(divisor) == 1.
    
    Bug: v8:6791
    Change-Id: I04cdc93f5ed2a696587c35c754e68f07012dd1a9
    Reviewed-on: https://chromium-review.googlesource.com/772332
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49433}
    b5997de8
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...