• Michael Achenbach's avatar
    Revert "[compiler] Remove dead code in CodeGenerator::BuildTranslation." · b501bf93
    Michael Achenbach authored
    This reverts commit 8d9de7ff.
    
    Reason for revert: Breaks roll:
    https://chromium-review.googlesource.com/c/chromium/src/+/806714
    
      # Fatal error in ../../v8/src/compiler/code-generator.cc, line 1032
      # unreachable code
    
      #3 v8::internal::compiler::CodeGenerator::AddTranslationForOperand()
      #4 v8::internal::compiler::CodeGenerator::TranslateFrameStateDescriptorOperands()
      #5 v8::internal::compiler::CodeGenerator::BuildTranslation()
      #6 v8::internal::compiler::CodeGenerator::AssembleInstruction()
      #7 v8::internal::compiler::CodeGenerator::AssembleCode()
      #8 v8::internal::compiler::PipelineImpl::AssembleCode()
    
    Original change's description:
    > [compiler] Remove dead code in CodeGenerator::BuildTranslation.
    > 
    > R=​jarin@chromium.org
    > 
    > Bug: 
    > Change-Id: Id219fb91c4c4f40677edea6f9c04763284e14373
    > Reviewed-on: https://chromium-review.googlesource.com/800934
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49831}
    
    TBR=jarin@chromium.org,neis@chromium.org
    
    Change-Id: I6f5e13e70dc816a4e0c4a362bd3a30091c14c637
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/807944Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49852}
    b501bf93
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...