• Leszek Swirski's avatar
    [turbofan] Add deopt reason to CheckIf · b4deef61
    Leszek Swirski authored
    CheckIf is lowered to DeoptimizeIfNot, but there is no deoptimization
    reason given in the deopt if that check fails (the reason is hardcoded
    to "no reason"). These deopts are annoying to track down.
    
    This patch makes CheckIf an operator with a DeoptimizeReason parameter,
    which is passed through to the DeoptimizeIfNot when lowered.
    A couple of checks are converted to give good deoptimize reasons (some
    new reasons are introduced), and the others are defaulted to kNoReason
    until someone else finds a use for them.
    
    Change-Id: I7e910cc9579ccf978dfe9d270ba7b98c8f6c2492
    Reviewed-on: https://chromium-review.googlesource.com/716479Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48506}
    b4deef61
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...