• jgruber's avatar
    Refactor data structures for simple stack traces · b4c1aefb
    jgruber authored
    Simple stack traces are captured through Isolate::CaptureSimpleStackTrace.
    Captured frames are stored in a FixedArray, which in turn is stored as a
    property (using a private symbol) on the error object itself. Actual formatting
    of the textual stack trace is done lazily when the user reads the stack
    property of the error object.
    
    This would involve many conversions back and forth between index-encoded raw
    data (receiver, function, offset and code), JS CallSite objects, and C++
    CallSite objects.
    
    This commit refactors the C++ CallSite class into a Struct class called
    StackTraceFrame, which is the new single point of truth frame information.
    Isolate::CaptureSimpleStackTrace stores an array of StackTraceFrames, and JS
    CallSite objects (now created only when the user specifies custom stack trace
    formatting through Error.prepareStackTrace) internally only store a reference
    to a StackTraceFrame.
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2230953002
    Cr-Commit-Position: refs/heads/master@{#38645}
    b4c1aefb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...