• Omer Katz's avatar
    [heap] Extend and rename NewSpace base class · b415cd7c
    Omer Katz authored
    NewSpace is renamed to SemiSpaceNewSpace and NewSpaceBase is renamed to
    NewSpace (the new PagedSpace new space implementation will be named
    PagedNewSpace).
    
    Most usecases are updated to use the base class rather than the concrete
    semi space based implementation. To that end, the base class is extended
    with additional virtual methods (for delegating to the concrete class).
    
    This CL follows these guidelines:
    (*) If at a method callsite we should know the exact new space
    implementation we use, we cast to the concrete class. This is the case
    for example for callsites in scavenger.*.
    (*) If a method is called from outside the heap implementation or should
    be present regardless of the concrete implementation, that method is
    made virtual.
    (*) Other cases are usually methods that are specific to a concrete
    implementation but the concrete implementation is not known at the
    callsite and there's no clear way to nicely abstract the method. In such
    cases we cast to the concrete SemiSpaceNewSpace implementation for now
    and we will revisit these cases once PagedNewSpace exists.
    
    Bug: v8:12612
    Change-Id: I7b85626774ce0d785b0257bf8d32b9f50eeaf292
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625975
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80482}
    b415cd7c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...