• rmcilroy's avatar
    [Interpreter] Localize the CanonicalHandleScope to parsing and renumbering. · b37daacd
    rmcilroy authored
    Ignition requires that objects which will be inserted into the
    constant pool are canonicalized (to enable off-thread bytecode
    generation). We created a CanonicalizeHandleScope across parse/compile
    however this impacts performance (~5-8% on CodeLoad).
    
    Now we localize the CanonicalHandleScope to only the parse /
    internalization and renumbering phases where objects are created which
    could end up in the constant array pool. This seems to address
    the performance regression.
    
    BUG=v8:5203,chromium:634953
    
    Review-Url: https://codereview.chromium.org/2318653002
    Cr-Commit-Position: refs/heads/master@{#39443}
    b37daacd
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...