• Michael Lippautz's avatar
    cppgc: Check for correct base class inheritance · 143e6a74
    Michael Lippautz authored
    The only valid way to define a GCed type T is by inheriting from
    GarbageCollected<T>. Since this is prone to typos (see tests), add a
    simple check that covers most interesting use cases.
    
    The static assert covers
      A -> B -> GarbageCollected<C>
    
    The static assert does not cover
     A -> B -> C -> GarbageCollected<B>
    
    (In order to do so, we would need __direct_bases() support which is
    not yet available for C++.)
    
    Bug: pdfium:1670, chromium:1056170
    Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73854}
    143e6a74
Name
Last commit
Last update
..
cppgc Loading commit data...
libplatform Loading commit data...
APIDesign.md Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol-1.3.json Loading commit data...
js_protocol.pdl Loading commit data...
v8-cppgc.h Loading commit data...
v8-fast-api-calls.h Loading commit data...
v8-inspector-protocol.h Loading commit data...
v8-inspector.h Loading commit data...
v8-internal.h Loading commit data...
v8-metrics.h Loading commit data...
v8-platform.h Loading commit data...
v8-profiler.h Loading commit data...
v8-unwinder-state.h Loading commit data...
v8-util.h Loading commit data...
v8-value-serializer-version.h Loading commit data...
v8-version-string.h Loading commit data...
v8-version.h Loading commit data...
v8-wasm-trap-handler-posix.h Loading commit data...
v8-wasm-trap-handler-win.h Loading commit data...
v8.h Loading commit data...
v8config.h Loading commit data...