-
svenpanne@chromium.org authored
With the upcoming changes to CALLBACKS properties, a predicate on the transition type alone doesn't make sense anymore: For CALLBACKS one has to look into the property's value to decide, and there is even the possibility of having a an accessor function *and* a transition in the same property. I am not completely happy with some parts of this CL, because they contain redundant code, but given the various representations we currently have for property type/value pairs, I can see no easy way around that. Perhaps one can improve this a bit in a different CL, the current diversity really, really hurts productivity... As a bonus, this CL includes a few minor things: * CaseClause::RecordTypeFeedback has been cleaned up and it handles the NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances, we previously missed some opportunities for monomorphic calls. In general, it is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a hack for the inability to remove a descriptor entry during GC, something callers shouldn't have to be aware of. * DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later CALLBACKS-related changes. * LookupResult::Print is now more informative for CONSTANT_TRANSITION. Review URL: https://chromiumcodereview.appspot.com/9320066 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
b34e202b
Name |
Last commit
|
Last update |
---|---|---|
benchmarks | ||
build | ||
include | ||
preparser | ||
samples | ||
src | ||
test | ||
tools | ||
.gitignore | ||
AUTHORS | ||
ChangeLog | ||
LICENSE | ||
LICENSE.strongtalk | ||
LICENSE.v8 | ||
LICENSE.valgrind | ||
Makefile | ||
SConstruct |