• Nikolaos Papaspyrou's avatar
    heap: Fix the tracing of GC cycles · 4ad20bff
    Nikolaos Papaspyrou authored
    Conceptually, a full GC cycle completes when the sweeping phase is
    finished. As sweeping is performed concurrently, this happens after
    Heap::CollectGarbage has returned and, at the latest, before the next
    full GC cycle begins. However, an arbitrary number of young GC cycles
    may happen in the meantime. Tracing information for the sweeping phase
    must be added to the corresponding full GC cycle event. Until now, this
    was not done correctly: this information was added to the GCTracer's
    current event and could thus be attributed to a subsequent young or full
    GC cycle.
    
    This CL introduces methods GCTracer::(Start|Stop)Cycle to delimit a
    cycle (still allowing for full GC cycles to be interrupted by young GC
    cycles). These methods are different from (Start|Stop)ObservablePause,
    which delimit the observable pause of each GC. The events of "pending"
    full GC cycles are kept until they are properly amended and reported,
    when the sweeping phase is finished.
    
    Bug: chromium:1154636
    Change-Id: I2fbc65d4807c78656d4abc8c451043f6f86211b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404733Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78905}
    4ad20bff
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...