• dehrenberg's avatar
    In Array.of and Array.from, fall back to DefineOwnProperty · b23c328f
    dehrenberg authored
    %AddElement is not intended for objects which are not arrays, and
    its behavior may go away with future refactorings. This patch gets
    rid of it if the receiver of from or of is not the intrinsic Array
    object.
    
    Array.of and Array.from previously papered over failures in calling
    [[DefineOwnProperty]] when setting array elements. This patch
    makes them lead to exceptions, and adds tests to assert that
    the appropriate exceptions are thrown.
    
    BUG=v8:4168
    R=adamk
    CC=rossberg,verwaest
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1181623003
    
    Cr-Commit-Position: refs/heads/master@{#28969}
    b23c328f
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...