• Andreas Haas's avatar
    [wasm] Add check that lazy compilation does not trigger a GC · b22f0e6d
    Andreas Haas authored
    For lazy compilation there is one generic lazy compilation builtin that
    spills all registers on the stack and then triggers the compilation of
    the called function. Some of these registers may contain references.
    If a GC was triggered during lazy compilation, the GC would have to
    know which spill slots on the stack contain references.
    
    This CL adds a check to guarantee that no GC can be triggered during
    lazy compilation. Thereby it is not necessary for the GC to know which
    spill slots contain references.
    
    If successful, lazy compilation indeed does not allocate on the heap
    and therefore cannot trigger a GC. However, when compilation fails, an
    error objects needs to be allocated and thrown. This allocation may
    trigger a GC, but that's not a problem, because the reference
    parameters which may get corrupted by the GC will not be used anyways,
    because the called function will never get executed after the failed
    compilation.
    
    R=clemensb@chromium.org
    
    Fixes: v8:11366
    Change-Id: Ic526d169d4e80ba83f517970ff234e669f854331
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599474Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80187}
    b22f0e6d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...