• Andreas Haas's avatar
    [wasm] Add check that lazy compilation does not trigger a GC · b22f0e6d
    Andreas Haas authored
    For lazy compilation there is one generic lazy compilation builtin that
    spills all registers on the stack and then triggers the compilation of
    the called function. Some of these registers may contain references.
    If a GC was triggered during lazy compilation, the GC would have to
    know which spill slots on the stack contain references.
    
    This CL adds a check to guarantee that no GC can be triggered during
    lazy compilation. Thereby it is not necessary for the GC to know which
    spill slots contain references.
    
    If successful, lazy compilation indeed does not allocate on the heap
    and therefore cannot trigger a GC. However, when compilation fails, an
    error objects needs to be allocated and thrown. This allocation may
    trigger a GC, but that's not a problem, because the reference
    parameters which may get corrupted by the GC will not be used anyways,
    because the called function will never get executed after the failed
    compilation.
    
    R=clemensb@chromium.org
    
    Fixes: v8:11366
    Change-Id: Ic526d169d4e80ba83f517970ff234e669f854331
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599474Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80187}
    b22f0e6d
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...