• Leszek Swirski's avatar
    Reland "[ic] Load name/context lazily in LdaNamedProperty" · b21cda74
    Leszek Swirski authored
    This reverts commit 5377e72c.
    
    Reason for revert: Looks like the relevant graphs didn't recover after
    this revert, which suggests that the regression was an unrelated
    secondary effect. Relanding the original change since the revert did
    cause some microbenchmark regressions.
    
    Original change's description:
    > Revert "[ic] Load name/context lazily in LdaNamedProperty"
    > 
    > This reverts commit 347092ac.
    > 
    > Not a clean revert, since other changes got baked on top, but rather
    > a manual removal of LoadLazyICParameters.
    > 
    > Reason for revert: Seems to actually regress bindings perf tests (see
    > bugs and https://chromeperf.appspot.com/group_report?rev=62539), doesn't
    > seem to improve performance elsewhere, and increases complexity.
    > 
    > Original change's description:
    > > [ic] Load name/context lazily in LdaNamedProperty
    > >
    > > Introduces LazyLoadICParameters which allow a LazyNode for context and
    > > name. These aren't used on the fast path, so we want to avoid reading
    > > them for both performance and register pressure reasons.
    > >
    > > Change-Id: Ifb637cf4782ce984feee9af503998e7539beb823
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1686665
    > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#62539}
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: chromium:981797
    > Bug: chromium:982630
    > Change-Id: I88af764d17afb76d6e64b95a3d1e4aaa1c6c8978
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934327
    > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65205}
    
    TBR=leszeks@chromium.org,verwaest@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:981797, chromium:982630, v8:10059
    Change-Id: I13754de06c83439e03e22cfaa7a14ce454076db9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973730Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65499}
    b21cda74
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...