• machenbach's avatar
    Revert of [intl] Remove redundant type checking system (patchset #4 id:60001... · b1e4f79e
    machenbach authored
    Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ )
    
    Reason for revert:
    Breaks noi18n.
    
    Original issue's description:
    > [intl] Remove redundant type checking system
    >
    > Previously, the Intl implementation tracked types two ways:
    >  - In the intl_initialized_marker_symbol
    >  - In various named properties of the intl_impl_object_symbol value
    >
    > As far as I can tell, these will never disagree with each other,
    > modulo bugs in Intl itself. This patch removes the second type
    > checking system.
    >
    > This reland includes a fixed type check for
    > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
    > method which is not bound. All future methods will follow this
    > pattern.
    >
    > BUG=v8:5751,chromium:677055, v8:4962
    > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
    >
    > Review-Url: https://codereview.chromium.org/2600913002
    > Cr-Commit-Position: refs/heads/master@{#42118}
    > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25
    
    TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5751,chromium:677055, v8:4962
    
    Review-Url: https://codereview.chromium.org/2617323002
    Cr-Commit-Position: refs/heads/master@{#42119}
    b1e4f79e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...