• fedor's avatar
    unicode-decoder: fix out-of-band write in utf16 · b199bcdd
    fedor authored
    `WriteUtf16Slow` should not assume that the output buffer has enough
    bytes to hold both words of surrogate pair. It should pass the number of
    remaining bytes to the `Utf8::ValueOf` instead, just as we already do in
    `Utf8DecoderBase::Reset`. Otherwise it will attempt to write the trail
    uint16_t past the buffer boundary, leading to memory corruption and
    possible crash.
    
    Originally reported by: Kris Reeves <kris.re@bbhmedia.com>
    
    BUG=v8:4274
    R=danno
    R=svenpanne
    LOG=y
    
    Review URL: https://codereview.chromium.org/1226493003
    
    Cr-Commit-Position: refs/heads/master@{#29485}
    b199bcdd
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...