• Benedikt Meurer's avatar
    [inspector] Improve class name inference. · b141fedf
    Benedikt Meurer authored
    Previously having a `Symbol.toStringTag` property holding a string
    somewhere in the prototype chain would always take predence over trying
    to determine a reasonable name from the "constructor" (in case of
    subclassing). This would lead to confusing behavior when diagnosing
    objects in DevTools, for example
    
    ```js
    class A extends URLSearchParams {};
    new A()
    ```
    
    would show `URLSearchParam` as class name for the instance rather than
    `A`.
    
    With this CL, we change the lookup logic to explicitly check for
    `Symbol.toStringTag` and "constructor" along each step of the prototype
    chain (skipping the "constructor" for the leaf object) and pick the
    first one that yields a string (that is the function debug name in case
    of "constructor").
    
    Fixed: chromium:980018
    Change-Id: Ic920b4bae02f965bc383c711f8de89c0de55fcac
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231078
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77453}
    b141fedf
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...