• Dan Elphick's avatar
    [api] Add Check method to Maybe · b121cde9
    Dan Elphick authored
    This new method returns no value and just verifies that the Maybe is not
    Empty. This is intended to be used for functions like Object::Set that
    return a Maybe<bool> but only use "emptiness" to indicate its result and
    where ToLocalChecked() appears to be discarding information.
    
    Also comments Object::Set to indicate that Check() is the preferred way
    of asserting that the Set should always succeed.
    
    R=yangguo
    
    Bug: v8:8562
    Change-Id: Ic3b45e42fa9ba0b53f1a764660a56041e64f087b
    Reviewed-on: https://chromium-review.googlesource.com/c/1414912Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58852}
    b121cde9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...