• jgruber's avatar
    [debug-wrapper] Further extend the debug wrapper · b06c4ce5
    jgruber authored
    This CL further extends the debug wrapper, migrates around 60 tests, and
    removes a few tests that use functionality we will not support anymore.
    
    In more detail:
    
    * Removed tests that use:
      * enable/disable individual breakpoints
      * invocationText()
      * the ScriptCollected event
      * showBreakPoints
      * evalFromScript (and similar)
      * mirror.constructedBy and mirror.referencedBy
      * event_data.promise()
    * Some frame.evaluate uses were adapted since due to differences between
      remote objects (inspector) and mirrors. For instance, exceptions are
      currently not recreated exactly, since the inspector protocol does not
      give us the stack and message separately. Other objects (such as
      'this' in debug-evaluate-receiver-before-super) need to be explicitly
      converted to a string before the test works correctly.
    * Ensure that inspector stores the script before sending ScriptParsed and
      ScriptFailedToParse events in order to be able to use the script from
      within those events.
    * Better remote object reconstruction (e.g. for undefined and arrays).
    * New functionality in wrapper:
      * debuggerFlags().breakPointsActive.setValue()
      * scripts()
      * execState.setVariableValue()
      * execState.scopeObject().value()
      * execState.scopeObject().property()
      * execState.frame().allScopes()
      * eventData.exception()
      * eventData.script()
      * setBreakPointsActive()
    
    BUG=v8:5530
    
    Review-Url: https://codereview.chromium.org/2497973002
    Cr-Commit-Position: refs/heads/master@{#41019}
    b06c4ce5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...