• Ross McIlroy's avatar
    [Compile] Ensure we don't reuse a feedback vector with a different layout than expected. · b06a134c
    Ross McIlroy authored
    If we flush the bytecode from a SFI we might recompile a JSFunction while the function
    still has its old feedback vector. This should usually be fine since the new and old
    feedback vectors have the same layout, however some bugs in the parser mean that it's
    possible for eagerly and lazily compiled eval functions to have different bytecode and
    so potentially different feedback vector layouts.
    
    For now reset the feedback vector if it doesn't have the same size when we compile the
    JSFunction, and recreate a new one of the correct layout. This will be replaced with a
    CHECK once the parser bugs are fixed.
    
    BUG=chromium:984344,v8:9511
    
    Change-Id: Ib8976f2541516f7a07e4d4ab7dc3c750dfe9b5d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708474
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62800}
    b06a134c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...