• Jakob Gruber's avatar
    [builtins] Verify Isolate compatibility with the embedded blob · b022e825
    Jakob Gruber authored
    Embedded builtins (= the embedded blob) have a few dependencies on the
    snapshot state. For instance, they require that metadata stored on
    builtin Code objects as well as the builtins constant table remain
    unchanged from mksnapshot-time. Embedders may violate these
    assumptions by accident, e.g. by loading a snapshot generated with
    different build flags, leading to seemingly unrelated failures later
    on.
    
    This CL introduces an Isolate hash stored in the embedded blob which
    hashes relevant parts of builtin Code objects and the builtins
    constant table. It's verified in Isolate::Init in debug builds.
    
    Bug: v8:8723
    Change-Id: Ifc9bdbe6f56ea67d8984f162afa73a3572cfbba8
    Reviewed-on: https://chromium-review.googlesource.com/c/1442641
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59177}
    b022e825
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...