• Adam Klein's avatar
    Hole check elimination: compare closure scopes instead of declaration scopes · afdf27fc
    Adam Klein authored
    Varblock scopes can be treated as the "same scope" as their surrounding
    function scope for the purposes of hole check elimination, as
    source position comparison is sufficient to determine statically that
    uses in the varblock scope are after initialization in the function scope.
    
    This allows the elimination of hole checks of lexically-bound parameter
    variables in functions with complex parameters, including rest parameters.
    
    The pre-existing code compared DeclarationScopes for legacy reasons:
    varblock scopes (and Scope::GetClosureScope()) did not exist at the
    time this code was originally written.
    
    R=neis@chromium.org
    
    Bug: v8:6344, v8:6414
    Change-Id: Ie787d58d1ea172e893788a9c716d3b6868980ab8
    Reviewed-on: https://chromium-review.googlesource.com/508242
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45405}
    afdf27fc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
DEPS.chromium Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...