• Clemens Backes's avatar
    [liftoff] Speed up check for debug info · f38e4093
    Clemens Backes authored
    The {NextInstruction} method is quite hot, since it's called for every
    since Wasm instruction. It currently does several checks to figure out
    if
    - a breakpoint needs to be emitted,
    - extra source positions are needed, or
    - tracing is active.
    
    The first two can only happen if we are generating debug code, hence
    check for that first. The last can only happen in debug mode, so it's
    not an issue in production.
    
    Finally, outline the emission of debug information. This leads to
    inlining of the {NextInstruction} method into callers, where it is a
    single check followed by a call to {EmitDebuggingInfo} (in release
    mode).
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: I5047406f55cd14c6c639528ef6e3422af27d16b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249671
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68399}
    f38e4093
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
liftoff-assembler-defs.h Loading commit data...
liftoff-assembler.cc Loading commit data...
liftoff-assembler.h Loading commit data...
liftoff-compiler.cc Loading commit data...
liftoff-compiler.h Loading commit data...
liftoff-register.h Loading commit data...