• Andreas Haas's avatar
    [wasm] Delete the AsyncCompileJob object just before ResolvePromise · af1a3091
    Andreas Haas authored
    At the moment the AsyncCompileJob object is deallocated after one of its
    task functions return false. This mechanism is, however, not documented,
    potentially error-prone, and I think there are already some cases where
    I think that we got it wrong.
    
    This CL moves the deallocation of the AsyncCompileJob object to the
    place where the promise which belongs to the AsyncCompileJob is either
    resolved or rejected. This is a more appropriate place to deallocate the
    object, because conceptionally, at the end of every an AsyncCompileJob
    its promise should either be resolved or rejected.
    
    R=clemensh@chromium.org, mtrofin@chromium.org
    
    Change-Id: I87618c5619a3ac923645d1c3f6acaee9b0b14a83
    Reviewed-on: https://chromium-review.googlesource.com/486884Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44896}
    af1a3091
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...