• Josh Wolfe's avatar
    [api] remove --harmony-function-tostring behavior from CompileFunctionInContext · aeb8f332
    Josh Wolfe authored
    The ')'-in-parameter checking is not necessary for
    CompileFunctionInContext. The arguments array is expected to be an
    array of identifiers, not an array of arbitrary strings that get
    concatenated.
    
    Furthermore, there's no reason to have the .toString() representation
    look like it came from CreateDynamicFunction(), and in fact inserting
    line breaks makes it more complicated to map line and column numbers
    correctly.
    
    Overall, the --harmony-function-tostring behavior only makes
    CompileFunctionInContext worse, so this CL removes it.
    
    R=littledan@chromium.org, adamk@chromium.org, caitp@igalia.com
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
    
    Bug: v8:4958
    Change-Id: Ifbc8a83216ca6a6979da1199972aa65f4bee36c3
    Reviewed-on: https://chromium-review.googlesource.com/558220Reviewed-by: 's avatarDaniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#46456}
    aeb8f332
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...