• Benedikt Meurer's avatar
    [async] Add Promise.all() support to --async-stack-traces. · 6f39ab89
    Benedikt Meurer authored
    This adds support for Promise.all() to --async-stack-traces (also at
    zero cost, since we can derive the relevant information from the resolve
    element closure and context). In case of `Promise.all(a)` the stack
    trace even tells you which element of `a` is responsible, for example
    
    ```js
    async function fine() {}
    async function thrower() { await fine(); throw new Error(); }
    async function test() { await Promise.all([fine(), thrower()]); }
    ```
    
    will generate the following stack trace
    
    ```
    Error
        at thrower (something.js:1:9)
        at async Promise.all (index 1)
        at async test (something.js:3:3)
    ```
    
    so it not only shows the async Promise.all() frames, but even tells the
    user exactly that the second element of `[fine(), thrower()]` is the
    relevant one.
    
    Bug: v8:7522
    Change-Id: I279a845888e06053cf0e3c9338ab71caabaabf45
    Reviewed-on: https://chromium-review.googlesource.com/c/1299248Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57023}
    6f39ab89
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...