• peterwmwong's avatar
    [builtins] Add fast paths to String.p.matchAll · ae4529f9
    peterwmwong authored
    Add fast paths when RegExp and RegExp result are fast wherever possible.
    
    As shown below, this CL improves the performance of calling S.p.matchAll and
    iterating over matches.
    
    Before:
    
    StringMatchAllBuiltinRegExpIteratorCreation-Strings(Score): 5002
    StringMatchAllBuiltinStringIteratorCreation-Strings(Score): 13798
    StringMatchAllBuiltinString-Strings(Score): 197
    StringMatchAllManualString-Strings(Score): 454
    StringMatchAllBuiltinRegExp-Strings(Score): 193
    StringMatchAllManualRegExp-Strings(Score): 453
    StringMatchAllBuiltinZeroWidth-Strings(Score): 97.2
    StringMatchAllBuiltinZeroWidthUnicode-Strings(Score): 95.9
    
    After:
    
    StringMatchAllBuiltinRegExpIteratorCreation-Strings(Score): 15437
    StringMatchAllBuiltinStringIteratorCreation-Strings(Score): 16708
    StringMatchAllBuiltinString-Strings(Score): 392
    StringMatchAllManualString-Strings(Score): 452
    StringMatchAllBuiltinRegExp-Strings(Score): 394
    StringMatchAllManualRegExp-Strings(Score): 484
    StringMatchAllBuiltinZeroWidth-Strings(Score): 409
    StringMatchAllBuiltinZeroWidthUnicode-Strings(Score): 413
    
    Bug: v8:6890
    Change-Id: I6fcc1003a471314cf412aac456d42286b2926810
    Reviewed-on: https://chromium-review.googlesource.com/1005400
    Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52581}
    ae4529f9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...