• Jungshik Shin's avatar
    Re-enable icu-timezone-data by default · ae314567
    Jungshik Shin authored
    icu-timezone-data was enabled before but reverted due to a perf issue.
    (sunspider/date-format-totfe regressed; crbug.com/769706 ).
    
    However, my in-Chrome test of the same test [1] shows that there's virtually
    no perf difference. See https://goo.gl/GX1jt6 .
    
    This will introduce a new behavior on POSIX(-like) platforms. Timezone
    names inside parentheses after GMT offset will not be 3-4 letter
    abbreviation any longer. They'll be human-readable names in the current
    default locale. This matches the current Windows behavior.
    
    new Date(2017, 5, 22).toString()
    new Date(2017, 11, 22).toString()
    
    Current:
    
    Thu Jun 22 2017 00:00:00 GMT-0700 (PDT)
    Fri Dec 22 2017 00:00:00 GMT-0800 (PST)
    
    New:
    
    Thu Jun 22 2017 00:00:00 GMT-0700 (Pacific Daylight Time)
    Fri Dec 22 2017 00:00:00 GMT-0800 (Pacific Standard Time)
    
    This CL will be followed by
      https://chromium-review.googlesource.com/c/v8/v8/+/572148 to
    implement https://github.com/tc39/ecma262/pull/778 .
    
    [1] http://jungshik.github.io/v8/cr769706.html
    
    BUG=v8:6031, v8:2137, v8:6076, chromium:769706
    TEST=mjsunit/icu-date-lord-howe.js, mjsunit/icu-date-to-string.js
    
    Change-Id: I22203670c3307a57fbf99e5f0a271dcbfbbef8fd
    Reviewed-on: https://chromium-review.googlesource.com/857333
    Commit-Queue: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51791}
    ae314567
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...