• Mythri A's avatar
    [turboprop] Record handle to map in dynamic map checks operator · adfdccc0
    Mythri A authored
    Monomorphic loads are quite common and it is important to keep these
    load accesses fast. Dynamic map checks increases the overhead for these
    monomorphic accesses by having to actually verify the IC state and check
    against a map from the feedback vector This was causing a significant
    (~2-3%) regression in JavaScript duration. To keep the common case of
    monomorphic checks fast, we now want to add a check against expected
    map (which passes in most cases) and move the rest of the checks to a
    builtin. i.e. we want dynamic map checks (when generating the code for
    loads in monomorphic state) to look like:
    
    if (incoming_map != HeapConstant(expected_map))
      call_builtin;
    
    This helps us to keep the most common case fast and still gets the
    benefits of dynamic map checks.
    
    This cl is the first in the series of cls that will add this
    functionality. This cl makes the expected_map available for dynamic map
    checks operator. In follow up cls, we will add a builtin and update
    the code to use the builtin.
    
    
    Bug: v8:10582
    Change-Id: I10992c6ba1fb005592de962310c208cff6829119
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2397894Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69798}
    adfdccc0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...